Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Correctly convert RestProperty to Assignable #339

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Correctly convert RestProperty to Assignable #339

merged 1 commit into from
Feb 10, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jan 31, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets Fixes #304 Fixes #309
License MIT

if the parsed spread is inside of an ObjectPattern we need to convert it to an assignable (ObjectExpression->ObjectPattern).
Also when parsing the spread inside a ObjectPattern we need to allow shorthand properties.

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@407c97c). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage          ?   97.65%           
=========================================
  Files             ?       20           
  Lines             ?     3327           
  Branches          ?      884           
=========================================
  Hits              ?     3249           
  Misses            ?       30           
  Partials          ?       48
Impacted Files Coverage Δ
src/parser/expression.js 97.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407c97c...7cb21c5. Read the comment docs.

@danez danez merged commit c79dd95 into master Feb 10, 2017
@danez danez deleted the fix-destruct branch February 10, 2017 14:36
@hzoo hzoo mentioned this pull request May 22, 2017
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect parsing of bind rest property doesn't validate patterns correctly in destructuring target
2 participants