This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix #336 by correctly setting arrow-param #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The param
refNeedsArrowPos
ofparseMaybeAssign()
wasn't populated in the failing case.Tbh this params (refShorthandDefaultPos, refNeedsArrowPos) are very magic to me and it takes a while to see what they do. When I have time again I will try to remove them and instead try to use the state for this with speaking names, but I'm not sure if that is possible.