This repository has been archived by the owner on May 19, 2018. It is now read-only.
Error on missing expected.json fixture in CI #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.57% (diff: 100%)@@ master #188 diff @@
==========================================
Files 19 19
Lines 3189 3189
Methods 333 333
Messages 0 0
Branches 839 839
==========================================
Hits 3016 3016
Misses 94 94
Partials 79 79
|
motiz88
added a commit
to motiz88/babel
that referenced
this pull request
Oct 16, 2016
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
|
So good!! |
danez
pushed a commit
to babel/babel
that referenced
this pull request
Oct 17, 2016
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
chrisprice
pushed a commit
to chrisprice/babel
that referenced
this pull request
Oct 18, 2016
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
This is much like Babylon's existing behavior around `expected.json`. The equivalent of babel/babylon#188 is already applied here, to guard against silent failure (and a potential false positive) if a test is accidentally committed without its expected.js.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks (in a CI environment) the default behavior of automatically creating missing
expected.jsonfiles, thereby guarding against silent failure (and a potential false positive) if a test is accidentally committed without itsexpected.json.