This repository has been archived by the owner on May 19, 2018. It is now read-only.
Allow "async" as identifier for object literal property shorthand #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but the test case should include a trailing comma, right? |
Current coverage is 96.15% (diff: 100%)@@ master #187 diff @@
==========================================
Files 19 19
Lines 3169 3169
Methods 333 333
Messages 0 0
Branches 832 832
==========================================
Hits 3047 3047
Misses 63 63
Partials 59 59
|
LOL. I love that I had a test case in the issue and I still made this mistake. Good catch 👍. I've pushed an update |
danharper
approved these changes
Oct 16, 2016
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186