Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs and add test: ignore and only take arrays as arguments #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agilgur5
Copy link

  • just passing a single regex causes errors:
    • Error: .ignore must be an array, or undefined
    • Error: .only must be an array, or undefined

- just passing a single regex causes errors:
  - Error: .ignore must be an array, or undefined
  - Error: .only must be an array, or undefined
- to ensure the docs I just fixed have a passing usage test somewhere
@agilgur5 agilgur5 changed the title fix docs: ignore and only take arrays as arguments fix docs and add test: ignore and only take arrays as arguments Nov 27, 2019
@agilgur5
Copy link
Author

Added ignore and only to the options test to ensure the docs I fixed have a passing test somewhere. Putting a single regex in (not array) causes it to error out.

It might be good to actually test the ignore option (right now the test confirms that nothing changes when it ignores a fake regex), but didn't want to change up the tests too much. The only option will cause errors if we remove some of the required files.

@agilgur5
Copy link
Author

The CI failure is unrelated to this code, test/options.js passes.

The test error seen in CI I was getting locally from a fresh clone too, so it predates this PR. The docs commit (which changes no actual code) also got this error in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant