Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with duplicate named exports #4538

Merged
merged 6 commits into from
Sep 21, 2016

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Sep 21, 2016

Fixing the tests to allow for the following babylon PR that throws on duplicate exports to land.

I will also make a 2nd PR removing the band-aid fix implemented in this PR as well as renaming the test files I created to follow the convention used in this PR. Coming up with unique test file names doesn't make a lot of sense since they were all in one file previously - numbering them has the same effect with less cognitive if and when more need to be added.

@codecov-io
Copy link

codecov-io commented Sep 21, 2016

Current coverage is 88.34% (diff: 100%)

Merging #4538 into master will not change coverage

@@             master      #4538   diff @@
==========================================
  Files           194        194          
  Lines         13621      13621          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3150       3150          
==========================================
  Hits          12033      12033          
  Misses         1588       1588          
  Partials          0          0          

Powered by Codecov. Last update a793107...b9ccba3

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Wasn't aware that it is that much changes. Really appreciate it.

@danez danez merged commit f3a6e4b into babel:master Sep 21, 2016
@hzoo
Copy link
Member

hzoo commented Sep 21, 2016

Thanks @kaicataldo! nice work

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 21, 2016
@kaicataldo kaicataldo deleted the disallow-duplicate-exports branch September 21, 2016 14:32
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
* Fix babel-plugin-transform-flow-strip-types tests

* Fix babel-plugin-transform-es2015-modules-umd tests

* Fix babel-generator tests

* Fix babel-plugin-transform-es2015-modules-systemjs tests

* Fix babel-plugin-transform-es2015-modules-commonjs tests

* Fix babel-plugin-transform-es2015-modules-amd tests
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants