Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shorthand of --skip-initial-build #3525

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

lxe
Copy link

@lxe lxe commented Jun 11, 2016

-s is already taken by --source-maps

I missed that unfortunately in my previous PR: #3489

@lxe
Copy link
Author

lxe commented Jun 11, 2016

Fortunately this just breaks the shorthand of --skip-initial-build and doesn't affect the correct behavior of -s and --source-maps

@loganfsmyth
Copy link
Member

Ahh good catch. Part of me wonders if it might be clearer to skip the shorthand for this entirely since -S overloading -s with two options that are very unrelated seems likely to confuse users.

@lxe lxe force-pushed the skip-shorthand branch from 2db57d1 to 4e14bdb Compare June 11, 2016 05:46
-s is already taken by --source-maps
@lxe lxe force-pushed the skip-shorthand branch from 4e14bdb to 2033c1d Compare June 11, 2016 05:46
@lxe lxe changed the title change shorthand of --skip-initial-build to -S remove shorthand of --skip-initial-build Jun 11, 2016
@loganfsmyth
Copy link
Member

Thanks!

@loganfsmyth loganfsmyth merged commit a7801b1 into babel:master Jun 11, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants