Replace trim-right with _.trimEnd in babel-helper-fixtures #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.83%
@@ master #3502 diff @@
==========================================
Files 194 194
Lines 10123 10122 -1
Methods 1537 1537
Messages 0 0
Branches 2246 2246
==========================================
- Hits 8891 8890 -1
Misses 1232 1232
Partials 0 0
|
|
Great! If you want you can make a single PR with multiple commits in the future for this kind of thing (if not it's ok too) |
hzoo
added
the
PR: Internal 🏠
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated babel-helper-fixtures to replace the
trim-rightdependency with_.trimEnd.