Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify babel-generator/node/index.js #3316

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

forivall
Copy link
Contributor

@forivall forivall commented Feb 4, 2016

The Node class was unused as a class, and the class was just being used as a bundle of static functions.

I noticed this while working on #3315.

Mostly indentation changes, see diff with whitespace changes ignored

The Node class was unused as a class
@codecov-io
Copy link

Current coverage is 85.18%

Merging #3316 into master will decrease coverage by -0.11% as of 970dae4

@@            master   #3316   diff @@
======================================
  Files          215     215       
  Stmts        15773   15759    -14
  Branches      3382    3382       
  Methods          0       0       
======================================
- Hit          13454   13424    -30
- Partial        688     712    +24
+ Missed        1631    1623     -8

Review entire Coverage Diff as of 970dae4

Powered by Codecov. Updated on successful CI builds.

@hzoo hzoo added PR: Internal 🏠 A type of pull request used for our changelog categories refactor labels Feb 4, 2016
@hzoo
Copy link
Member

hzoo commented Feb 4, 2016

Do we want to rename the filename from node? I guess it's still good

@amasad
Copy link
Member

amasad commented Feb 4, 2016

Can we run a quick benchmark to make sure there is no perf regression? Just parse and generate something like jQuery before and after. Thank you

@hzoo
Copy link
Member

hzoo commented Feb 4, 2016

Like the one mentioned in https://phabricator.babeljs.io/T6884

@forivall
Copy link
Contributor Author

forivall commented Feb 4, 2016

benchmark code: https://gist.github.com/forivall/d303673559be900526ce

before

babylon 125
babel generator (cold) 400
babel generator (warm 1) 224
babel generator (warm avg) 225.46

after

babylon 122
babel generator (cold) 404
babel generator (warm 1) 229
babel generator (warm avg) 225.51

@hzoo
Copy link
Member

hzoo commented Feb 4, 2016

Ok great, negligible

@amasad
Copy link
Member

amasad commented Feb 4, 2016

cool, thanks!

amasad added a commit that referenced this pull request Feb 4, 2016
@amasad amasad merged commit bcc32da into babel:master Feb 4, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants