-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More relaxed displayName
inference
#3216
Conversation
@spicyj What do you think of this change? |
…e from rather than just checking the direct parent
7852c01
to
05896b8
Compare
Seems all right. I don't feel too strongly. |
👍 |
Current coverage is
|
More relaxed `displayName` inference
Thank you! |
This still appears be an issue for me using react-transform with react-transform-hmr and doing: export default React.createClass({...}) Namely, don't seem to hit any of the statements here. I'm on |
@colindresj Maybe this is your case also: gaearon/babel-plugin-react-transform#96 |
Causes the
displayName
of:to be inferred as
foo
despite not being the direct parent.