Never print comments in compact mode

[amasad]

No description provided.

[codecov-io]

Current coverage is 84.91%

Merging #3146 into master will not affect coverage as of 7580de8

@@            master   #3146   diff @@
======================================
  Files          214     214       
  Stmts        15589   15589       
  Branches      3326    3326       
  Methods          0       0       
======================================
  Hit          13237   13237       
  Partial        680     680       
  Missed        1672    1672       

Review entire Coverage Diff as of 7580de8

Powered by Codecov. Updated on successful CI builds.

[goto-bus-stop]

should this be !compact && (@license || @preserve)?

[amasad]

The precedence works out. || has higher precedence

On Monday, December 7, 2015, René Kooi [email protected] wrote:

In packages/babel-generator/src/printer.js
#3146 (comment):

@@ -231,7 +231,7 @@ export default class Printer extends Buffer {
if (this.format.shouldPrintComment) {
return this.format.shouldPrintComment(comment.value);
} else {

•  if (comment.value.indexOf("@license") >= 0 || comment.value.indexOf("@preserve") >= 0) {
  

•  if (!this.format.compact && comment.value.indexOf("@license") >= 0 || comment.value.indexOf("@preserve") >= 0) {
  

should this be !compact && (@license || @preserve)?

—
Reply to this email directly or view it on GitHub
https://github.com/babel/babel/pull/3146/files#r46809012.

[hzoo]

Doesn't && have higher precedence?

[amasad]

huh, maybe, I'll just add parens ;P

[hzoo]

Ex:

false && true  || true      // returns true
false && (true || true)     // returns false