-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacing in binary expression when right is a binary expression and has a unary on the left #3121
Conversation
…d has a unary on the left
@@ -2,3 +2,5 @@ | |||
1 && 1; | |||
1 + +1; | |||
x + ++y; | |||
(a+(+b)*2); | |||
a + + b * 2 * 2 * 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should get some -
cases in here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Current coverage is
|
Fix spacing in binary expression when right is a binary expression and has a unary on the left
👍 looks good. |
@amasad This fixes the issue, but for example input |
I do care. Thanks for pointing that out. I'll look into taking prenthesized On Tuesday, December 1, 2015, phantom10111 [email protected] wrote:
|
@amasad Yes, I can confirm it works as expected now. Thanks! |
Can add |
Fixes https://phabricator.babeljs.io/T6736
cc @loganfsmyth @spicyj @sebmck