Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unknown/any in TS catch clause param #11755

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Allow unknown/any in TS catch clause param #11755

merged 1 commit into from
Jun 30, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Jun 27, 2020 •
edited by nicolo-ribaudo
Loading

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/#unknown-on-catch

Merged to #11760, not landed in main yet.

@existentialism existentialism added area: typescript PR: New Feature 🚀 A type of pull request used for our changelog categories labels Jun 27, 2020
@existentialism existentialism added this to the 7.11.0 milestone Jun 27, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8987d18:

Sandbox Source
morning-thunder-zmlnt Configuration
admiring-perlman-6g9s3 Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 27, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24878/

@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.11.0/ts-4.0 June 29, 2020 23:07
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jun 29, 2020
Merged
4 tasks
@existentialism existentialism added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jun 30, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 2e52107 into feat-7.11.0/ts-4.0 Jun 30, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the ts4-catchunknown branch June 30, 2020 08:40
@JLHwung JLHwung mentioned this pull request Jun 30, 2020
Merged
nicolo-ribaudo pushed a commit that referenced this pull request Jul 15, 2020
@existentialism @nicolo-ribaudo
Allow unknown/any in TS catch clause param (#11755)
981cb8f
JLHwung pushed a commit that referenced this pull request Jul 29, 2020
@existentialism @JLHwung
Allow unknown/any in TS catch clause param (#11755)
8a1d7e4
@alangpierce alangpierce mentioned this pull request Sep 21, 2020
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung left review comments

@kaicataldo kaicataldo kaicataldo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
7.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@existentialism @babel-bot @JLHwung @nicolo-ribaudo @kaicataldo