-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows to travis #10249
Add windows to travis #10249
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11717/ |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11209/ |
Good idea. For inspiration I have a similar setup here https://github.com/xtuc/webassemblyjs/blob/master/appveyor.yml#L11, with Make, lerna, etc. |
Travis throws that Also, I'll disable tests on older node versions; I think that it is enought to test only one with windows. |
I guess we would need #9674 first? I want to start on this soon. |
We can have a |
4157c70
to
8948206
Compare
1fa7237
to
43f6795
Compare
# Conflicts: # Makefile
sources should be URL.
65cf75a
to
8852519
Compare
.../babel-plugin-transform-react-jsx-source/test/fixtures/react-source/with-source/options.json
Outdated
Show resolved
Hide resolved
✔️ (I can't approve my own PR) |
✔️(me neither) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad we finally got this in!
Curious of how to maintain adding .replace(/\\/g, "/")
everywhere but I guess that's exactly what this CI is for when we encounter that issue!
* Add windows to travis * Update * Do not use sh file on windows * Fix whitespace * Unify command * ./ doesn't work on windows * Remove all ./ usages * Run windows test before others * fix: normalize filename when generating sources sources should be URL. * fix: replace normalized path to cwd * chore: add nodePlatform task options * fix: normalize preset-env filename output * chore: replace normalized path to CWD on win32 platform * limit transform-react-source to run on linux and darwin * test: escapeRegExp on testcases * test: add test for babel --filename on windows * test: double babel-node/cli test timeout * chore: workaround windows build does not stop * chore: remove redundant condition * refactor: rename `nodePlatform` to `os`
* Add windows to travis * Update * Do not use sh file on windows * Fix whitespace * Unify command * ./ doesn't work on windows * Remove all ./ usages * Run windows test before others * fix: normalize filename when generating sources sources should be URL. * fix: replace normalized path to cwd * chore: add nodePlatform task options * fix: normalize preset-env filename output * chore: replace normalized path to CWD on win32 platform * limit transform-react-source to run on linux and darwin * test: escapeRegExp on testcases * test: add test for babel --filename on windows * test: double babel-node/cli test timeout * chore: workaround windows build does not stop * chore: remove redundant condition * refactor: rename `nodePlatform` to `os`
This PR is collaborated by @nicolo-ribaudo and @JLHwung.
In this PR, we
os
to babel-helper-fixtures, which specifies the operating system that the test will run on