Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for node 14.15.0 #963

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Build for node 14.15.0 #963

merged 4 commits into from
Oct 26, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 25, 2022

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Build for Node.js 14.15.0 and update @babel/* dev deps.

@JLHwung JLHwung force-pushed the bump-babel-and-deps branch from e2dd146 to 7248731 Compare October 26, 2022 14:08
@@ -54,10 +57,10 @@ test.cb("should transpile the code snippet", t => {
t.true(files.length === 1);
fs.readFile(path.resolve(t.context.directory, files[0]), (err, data) => {
t.is(err, null);
const test = "var App = function App()";
const test = "var App = function App(arg)";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing because new Babel version generates slightly different outputs. I have updated the test Babel config and ensured that the test Babel config does not inherit root Babel config.

@nicolo-ribaudo nicolo-ribaudo merged commit 29de619 into main Oct 26, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the bump-babel-and-deps branch November 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants