-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use async config loading if available #825
Conversation
I have no idea why sourcemaps test fails on Windows in my branch. Probably, some dependency in the newer Babel returns broken Windows paths. |
the AppVeyor CI error is not directly related to this change, but babel changed some path related behaviour from 7.2.0 to 7.8.0 |
@JLHwung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We can investigate that failure separately if needed.
@@ -127,3 +127,38 @@ test.cb( | |||
}); | |||
}, | |||
); | |||
|
|||
test.cb("should load ESM config files", t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we differentiate this test based on process.version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it, but I don't know if Node team will backport ESM to 12 or even 10 in the future and this test begin to fail. But okay, I'll redo it with semver check of Node version. As I remember 13.3
was the first one without --experimental
flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's only test in on 13.3 for now. If they'll backport it we can update the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
So, I've tried to overcome ESM loading on Window. But even in case of using file urls according to Node it fails. This time because of
|
The windows bug should be fixed by babel/babel#11193. |
@nicolo-ribaudo So, what do we do? Leave local path as it is now, rollback to |
Let's wait for now, I'll release a patch version when there Babel PR is fixed. |
Can this be merged now? |
074e4b3
to
28fe5ce
Compare
5152606
to
7702c8f
Compare
7702c8f
to
2385e81
Compare
5eb515d
to
a20ba70
Compare
Thanks! |
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Fixes #824
What is the new behavior?
If
@babel/core
is>=7.8.0
, then ESM config will be found and loaded asynchronously.Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: