Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel-loader logger #1034

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add babel-loader logger #1034

merged 1 commit into from
Sep 3, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 27, 2024

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
babel-loader does not output very much debug logs

What is the new behavior?
When the webpack option stats.loggingDebug is set to includes babel-loader, the loader will now output detailed debug logs, which could help users trouble shooting common errors, such as insufficient cache folder permissions or debugging babel-loader overrides.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
This PR is based on #1033, I will rebase once that PR gets merged.

As this PR is for the 10.0 milestone, I will prepare a new readme PR that should be merged before we release 10.0.

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 3, 2024

Since this feature should help users providing more debug message when reporting babel-loader bugs. Do you think we should backport this feature to the 9.x? The stats.loggingDebug option has been available since webpack 4, so we could do that for the 8.x as well.

We can cut the 9.x branch from e449287.

JLHwung added a commit that referenced this pull request Sep 3, 2024
@JLHwung JLHwung mentioned this pull request Sep 3, 2024
@JLHwung JLHwung merged commit a0c450d into main Sep 3, 2024
16 checks passed
@JLHwung JLHwung deleted the add-babel-loader-logger branch September 4, 2024 14:00
nicolo-ribaudo pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants