breaking: use output.hashFunction as loader cache hasher #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on #1026 as the |
JLHwung
force-pushed
the
use-webpack-output-hashfunction-as-loader-cache-hashfunction
branch
2 times, most recently
from
d51c415 to
41cacd9
Compare
JLHwung
force-pushed
the
use-webpack-output-hashfunction-as-loader-cache-hashfunction
branch
from
41cacd9 to
9e6f6d0
Compare
JLHwung
commented
Jul 15, 2024
| @@ -181,13 +181,17 @@ async function loader(source, inputSourceMap, overrides) { | |||
|
|
|||
| let result; | |||
| if (cacheDirectory) { | |||
| const hash = this.utils.createHash( | |||
| this._compilation.outputOptions.hashFunction, | |||
| ); | |||
There was a problem hiding this comment.
nicolo-ribaudo
approved these changes
Jul 16, 2024
liuxingbaoyu
approved these changes
Jul 16, 2024
JLHwung
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
The babel-loader hash function can not be changed by users. It will use
sha256and then fallback tomd5.What is the new behavior?
The hash function is now determined by the webpack option
output.hashFunction. This opens the door to more performant hash such as the future webpack defaultsxxhash64. Plus we don't have to update the hash function again if in the future OpenSSL drops more unsafe crypto hash functions, since users can provide the desiredhashFunctionin the webpack config.Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
The cache filename might be changed because now it aligns to the webpack option
output.hashFunction, which may be different than our previous hash function choice.Other information: