Update tests #1003
Merged
Update tests #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel-loader 9 only supports webpack 5
In webpack 5.0.0, the mapObj.sources are [ 'webpack://babel-loader/./test/fixtures/basic.js', 'webpack://babel-loader/./test/fixtures/constant.js', 'webpack://babel-loader/./test/fixtures/import.js', 'webpack://babel-loader/webpack/bootstrap', 'webpack://babel-loader/webpack/startup' ] In later versions the `'webpack://babel-loader/./test/fixtures/basic.js'` is moved after webpack bootstrap, causing different indices across different webpack versions.
nicolo-ribaudo
approved these changes
Jun 19, 2024
|
Yes, webpack 5.80.0 introduced ESM loader support, see #1002. |
liuxingbaoyu
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Does this PR introduce a breaking change?
Other information: In preparation to the ESM migration, this PR migrates current tests from callback style to promise styles. We also add Node 20 to the CI matrix.