VSCode + Calva + nRepl - typing * causes SyntaxError in nbb

[davidyang]

[ To keep development of this project going, consider sponsoring. If you are
already a sponsor, thank you! ]

version

nbb v1.1.151

platform

MacOS 13
Node 16.15.0

problem

• Start a nbb script
• Start a nREPL server
• Connect from VSCode Calva
• Type *

I get this error in the console:

SyntaxError: Invalid regular expression: /*/: Nothing to repeat
    at new RegExp (<anonymous>)
    at Object.$APP.xj (file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:150:174)
    at file:///Users/davidtest/node_modules/nbb/lib/nbb_api.js:15:492
    at file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:974:214
    at file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:974:227
    at Nf (file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:92:145)
    at $APP.Mf.$APP.l.ea (file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:905:22)
    at Object.$APP.w (file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:67:94)
    at file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:917:70
    at Nf (file:///Users/davidtest/node_modules/nbb/lib/nbb_core.js:92:145)

repro

This file as test.cljs works for me to reproduce the error whenever I type *

(ns test
  (:require  [nbb.nrepl-server :as nrepl]))

(nrepl/start-server! {:port 1337})

*

expected behavior

No syntax error.

[borkdude]

Hi @davidyang - I have problems reproducing this with Calva and nbb (1.1.151). Maybe I'm missing something?

[davidyang]

Thanks for the quick response Michiel! It seems like it happens when I try to autocomplete, not evaluate the expression. So if I put cursor right after the * and press Ctrl-Space I get the error in the console. Evaluation continues to work. It seems to me like maybe Calva is trying to get some info from LSP and nbb is trying to read the file and having issues?

…

On Wed, Dec 14, 2022 at 10:11 AM Michiel Borkent ***@***.***> wrote: Hi @davidyang <https://github.com/davidyang> - I have problems reproducing this with Calva and nbb (1.1.151). Maybe I'm missing something? [image: Screenshot 2022-12-14 at 16 06 46] <https://user-images.githubusercontent.com/284934/207632291-19ce25d2-4c74-448e-b634-d31b443626bd.png> — Reply to this email directly, view it on GitHub <#288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACNRNYYLHURLKYRHNVSWTWNHPQ7ANCNFSM6AAAAAAS6SCMNQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[borkdude]

OK, the culprit is likely here:

nbb/src/nbb/impl/repl_utils.cljs

Line 23 in e2b5679

(let [pat (re-pattern query)]

which can be reproduced using:

cljs.user=> (re-pattern "*")
Execution error (SyntaxError) at (<cljs repl>:1).
Invalid regular expression: nothing to repeat

which can be fixed like this:

cljs.user=> (re-pattern (str/replace "*" #"[.*+?^${}()|[\]\\]" "\\$&"))
#"\*"
cljs.user=> (re-find (re-pattern (str/replace "*" #"[.*+?^${}()|[\]\\]" "\\$&")) "foo*foo")

(cf https://stackoverflow.com/questions/3446170/escape-string-for-use-in-javascript-regex)

[borkdude]

Thanks for the issue. Now publishing 1.1.152.

[davidyang]

Awesome - thanks for the quick response!

…

On Wed, Dec 14, 2022 at 1:08 PM Michiel Borkent ***@***.***> wrote: Thanks for the issue. Now publishing 1.1.152. — Reply to this email directly, view it on GitHub <#288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACNRMYAS5U7WKPSZCDZOTWNIELXANCNFSM6AAAAAAS6SCMNQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>