Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental URI path decoding in uri-with-query #67

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

hxtmdev
Copy link
Contributor

@hxtmdev hxtmdev commented Sep 10, 2024

This changes URI getPath to getRawPath to prevent accidental decoding.

Please answer the following questions and leave the below in as part of your PR.

This changes URI getPath to getRawPath to prevent accidental decoding.
@borkdude
Copy link
Contributor

Thanks! Can you also create an issue like the PR template suggests and mention the issue number in the changelog?

@hxtmdev
Copy link
Contributor Author

hxtmdev commented Sep 10, 2024

Thanks! Can you also create an issue like the PR template suggests and mention the issue number in the changelog?

Sure, I noticed the behavior and was prodding around trying to find out if it's maybe my own fault when I already had the fix. Wasn't sure if you really preferred an issue in that case and took the template question as really just a question. Will open one directly next time 😉

@borkdude borkdude merged commit 132ffc3 into babashka:main Sep 10, 2024
3 checks passed
@borkdude
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants