Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add num_timepoints & num_docs_by_timepoint for DTModel #59

Closed
bab2min opened this issue Jun 9, 2020 · 3 comments · Fixed by #64
Closed

add num_timepoints & num_docs_by_timepoint for DTModel #59

bab2min opened this issue Jun 9, 2020 · 3 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@bab2min
Copy link
Owner

bab2min commented Jun 9, 2020

The current tomotopy.DTModel is missing some features about the number of timepoints and documents. Suggest adding following properties into DTModel.

  • num_timepoints (or t) : the value that is input as t of __init__
  • num_docs_by_timepoint : the number of documents belonging to each timepoint
@bab2min bab2min added the enhancement New feature or request label Jun 9, 2020
@ebergam
Copy link

ebergam commented Jul 11, 2020

Hi @bab2min , thanks a lot for this great work!

Are you planning to implement these features soon? It is quite crucial to be able to use the num_docs_by_timepoints parameter in order to be able to use your library.

This is another interesting resource you might be interested in https://github.com/GSukr/dtmvisual

thanks a lot!

@bab2min
Copy link
Owner Author

bab2min commented Jul 12, 2020

Hello @ebergam, thanks for your attention to my work!
Currently I'm implementing the next version of tomotopy, and it will include this enhancement. So please wait a few more days.

@ebergam
Copy link

ebergam commented Jul 12, 2020

Great, looking forward!
Thank you @bab2min :)

bab2min added a commit that referenced this issue Jul 14, 2020
fixed #59, partially fixed #63
@bab2min bab2min mentioned this issue Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants