Bootstrap4 Navigation bar added (adapted from Bootstrap3 Navigation bar) #120
Conversation
|
Hi @sanjayminni , thanks for contributing. Can you specify what do you mean by "adapted"? Bootstrap 4 describes a navbar here https://getbootstrap.com/docs/4.0/components/navbar/ . Does your solution conforms with it? Last but not least, could you write some unit tests? |
|
Hi Francisco,
*_ please note I am not a guru or a skilled programmer _*
by adapted I meant I had taken the willow Bootstrap 3 as base for
functionalities and modified it as required native to Bootstrap4
Yes I have tried to match the code to the first example here
https://getbootstrap.com/docs/4.0/components/navbar/ as the objective
here is the code this class generates with my unit test
<nav class="navbar navbar-expand-lg navbar-light bg-light">
<a id="a-id6" class="navbar-brand">SampleBS4</a>
<button class="btn navbar-toggler" data-toggle="collapse" data-target=
"#container-id7" aria-controls="navbarSupportedContent" aria-expanded=
"false" aria-label="Toggle navigation" type="button">
<span class="navbar-toggler-icon"></span>
</button>
<div id="container-id7" class="collapse navbar-collapse">
<ul class="navbar-nav">
<li class="nav-item">
<a id="a-id9" target="_blank" rel="noopener noreferrer" class=
"nav-link" href="
<http://localhost:8080/mintst?_s=b9SszZR_BFZvhXI4&_k=Z5eaRpqGyhpM-8Mb>"
Home</a>
</li>
<li class="nav-item">
<a id="a-id10" class="nav-link">Link</a>
</li>
</ul>
</div>
</nav>
<div id="willow-dialog-section" class="willow-dialog-container"></div>
<div id="willow-notification-section"></div>
I can write a set of unit tests - however what i want to know is - how do
you usually get the code fragment to assert the test against - do you take
a code generated by a working test and insert it or is there any other
way.
with warm regards
Sanjay Minni
…On Fri, 23 Jul 2021 at 17:09, Francisco Ortiz Peñaloza < ***@***.***> wrote:
Hi @sanjayminni <https://github.com/sanjayminni> , thanks for
contributing.
Can you specify what do you mean by "adapted"? Bootstrap 4 describes a
navbar here https://getbootstrap.com/docs/4.0/components/navbar/ . Does
your solution conforms with it?
Last but not least, could you write some unit tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3ZGLWMB36WMLK4TGHBQV3TZFIGTANCNFSM5AZRUHIA>
.
|
|
Hi Sanjay. You'd need to create a The expected html code would be the one presented in the Bootstrap site for that feature, trying to use as little components as possible, so that we are testing mainly the way the navigator bar is rendered, but keeping it "valid" (that is, no empty bar unless that makes sense in a bootstrap 4 app, etc.). Lets us know if that answers your question, and many thanks for your participation in the project! |
|
Hi Ignore this PR. I had only made a couple of changes in 1 class but this is showing the whole lot. something wrong in the way I forked / committed etc. this https://discord.com/channels/223421264751099906/311419918631305218/879654296566784020 anyway will try to redo and submit with test cases. am deleting this clone |
Hi I have adapted a Bootstrap4 Navigation Bar from the Bootstrap3 Navigation Bar - you can check if its useful and adopt it into the willow-bootstrap. thanks