Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test to check caching directives are kept in Not Modified res… #179

Conversation

gcotelli
Copy link
Member

…ponse

Fix #178

@gcotelli gcotelli self-assigned this Nov 21, 2023
jvanecek
jvanecek previously approved these changes Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (346e02b) 99.53% compared to head (767df30) 99.53%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-candidate     #179   +/-   ##
==================================================
  Coverage              99.53%   99.53%           
==================================================
  Files                    164      164           
  Lines                  12994    13002    +8     
==================================================
+ Hits                   12933    12941    +8     
  Misses                    61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli merged commit a1ca293 into release-candidate Nov 21, 2023
92 checks passed
@gcotelli gcotelli deleted the 178-The-304-responses-should-have-the-caching-policies-as-a-200-would- branch November 21, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 304 responses should have the caching policies as a 200 would
2 participants