Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default command line handler to not exit the gem unless specified by the user #53

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

gcotelli
Copy link
Member

@gcotelli gcotelli commented Jan 8, 2024

Some applications are forking background processes, and not expecting the main process to terminate. In Launchpad application termination is explicit by calling exitSuccess or exitError.
This change make the GS64 code compatible with Pharo.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (445ccb9) 99.78% compared to head (3b8435d) 99.78%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-candidate      #53   +/-   ##
==================================================
  Coverage              99.78%   99.78%           
==================================================
  Files                     56       56           
  Lines                   3688     3688           
==================================================
  Hits                    3680     3680           
  Misses                     8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli merged commit 17dad7c into release-candidate Jan 9, 2024
55 checks passed
@gcotelli gcotelli deleted the do_not_automatically_end_application branch January 9, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants