Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GemStone 64 #51

Merged
merged 32 commits into from
Sep 21, 2023
Merged

Add support for GemStone 64 #51

merged 32 commits into from
Sep 21, 2023

Conversation

gcotelli
Copy link
Member

@gcotelli gcotelli commented Sep 19, 2023

  • Add rowan specs
  • Split some packages including Pharo-specific code
  • Make TCP command server optional (and only available in Pharo by now)
  • Refactor environment variable access to use the facilities in the language platform
  • Port the useful parts of CommandLineArguments and CommandLineHandler to GS, and move the other methods to a compatibility package to not break Pharo when loaded.
  • Provide a GS64 version of StackTraceTextDumper

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9c57522) 99.78% compared to head (e168b01) 99.78%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-candidate      #51   +/-   ##
==================================================
  Coverage              99.78%   99.78%           
==================================================
  Files                     56       56           
  Lines                   3646     3688   +42     
==================================================
+ Hits                    3638     3680   +42     
  Misses                     8        8           
Files Changed Coverage Δ
...Commands-Pharo-Tests/TCPCommandServerTest.class.st 100.00% <ø> (ø)
...Launchpad-Commands-Pharo/TCPCommandServer.class.st 100.00% <ø> (ø)
...e/Launchpad-Commands/LaunchpadRootCommand.class.st 100.00% <ø> (ø)
...lications/CurrentApplicationConfiguration.class.st 100.00% <100.00%> (ø)
...unchpad-Applications/LaunchpadApplication.class.st 100.00% <100.00%> (ø)
...hpad-Applications/ReleasedApplicationMode.class.st 100.00% <100.00%> (ø)
...nds-Pharo/LaunchpadTCPCommandServerOption.class.st 100.00% <100.00%> (ø)
...d-Commands-Tests/LaunchpadRootCommandTest.class.st 100.00% <100.00%> (ø)
source/Launchpad-Commands/LaunchpadOption.class.st 100.00% <100.00%> (ø)
...Commands/LaunchpadStartApplicationCommand.class.st 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli marked this pull request as ready for review September 21, 2023 14:31
mtabacman
mtabacman previously approved these changes Sep 21, 2023
@gcotelli gcotelli merged commit 129f6a4 into release-candidate Sep 21, 2023
67 checks passed
@gcotelli gcotelli deleted the gs64 branch September 21, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants