Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions and tooling to support transient, invariant and non-persistent GS64 options in Tonel #121

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

gcotelli
Copy link
Member

@gcotelli gcotelli commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (de082b1) to head (9230fe9).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-candidate      #121   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
===================================================
  Files                     81        81           
  Lines                   7408      7408           
===================================================
  Hits                    7408      7408           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/how-to/how-to-support-gs64-options.md Outdated Show resolved Hide resolved
docs/how-to/how-to-support-gs64-options.md Outdated Show resolved Hide resolved
docs/how-to/how-to-support-gs64-options.md Outdated Show resolved Hide resolved
docs/how-to/how-to-support-gs64-options.md Outdated Show resolved Hide resolved
docs/how-to/how-to-support-gs64-options.md Outdated Show resolved Hide resolved
source/Buoy-Development-Tools/Behavior.extension.st Outdated Show resolved Hide resolved
source/Buoy-Development-Tools/Behavior.extension.st Outdated Show resolved Hide resolved
Co-authored-by: Maximiliano Tabacman <[email protected]>
@gcotelli gcotelli requested review from mtabacman and ytsejam78 April 4, 2024 11:23
@gcotelli gcotelli merged commit a3f98ee into release-candidate Apr 4, 2024
46 checks passed
@gcotelli gcotelli deleted the gs64_tools branch April 4, 2024 12:38
by filling the `gs_options` metadata in the class creation section. However,
by default Pharo will remove this metadata when committing code losing the
Pharo will be default remove this metadata when committing code, which loses these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pharo will be default remove this metadata when committing code, which loses these
Pharo will by default remove this metadata when committing code, which loses these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants