-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heading #1537
Fix heading #1537
Conversation
Fix heading not rendering correctly.
I still need to fix this properly. I realise now the text is part of the heading, but it's the heading itself is broken for some reason. I'll need to do that when I'm back at my laptop with a decent Markdown editor. |
Hey @martincostello Thanks for pointing that out. The simple fix is the wrong whitespace between Anyway - the fix belongs to you ;) |
Be gone, crazy space.
Thanks - that would have taken me ages to puzzle out 😆 |
LGTM and big thanks @martincostello ! |
Imagine the first time I stumbled across this "feature" :D |
@egil Disabling the "ghost" workflows didn't help, unfortunately. |
* Fix heading Fix heading not rendering correctly. * Fix heading Be gone, crazy space.
* docs: Fix heading (#1537) * Fix heading Fix heading not rendering correctly. * Fix heading Be gone, crazy space. * docs: Fix AddFakePersistentComponentState examples (Fixes #1539) (#1540) --------- Co-authored-by: Martin Costello <[email protected]> Co-authored-by: Steven Giesel <[email protected]>
Pull request description
Fix heading not rendering correctly.
Separately the sentence doesn’t seem right, like something was accidentally deleted, but I’m not sure what it was. I can tweak that too if needed if you let me know what it is.
PR meta checklist
main
branch for codeor targeted at
stable
branch for documentation that is live on bunit.dev.Code PR specific checklist