fix: New up renderer for markup matches #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdotnet
force-pushed
the
fix/fragment-container
branch
from
65144e7
to
2e1468f
Compare
linkdotnet
commented
Jul 19, 2023
egil
reviewed
Jul 21, 2023
tests/bunit.web.tests/EventDispatchExtensions/GeneralEventDispatchExtensionsTest.cs
Outdated
Show resolved
Hide resolved
egil
reviewed
Jul 21, 2023
linkdotnet
force-pushed
the
fix/fragment-container
branch
from
db8f87e
to
784749d
Compare
egil
approved these changes
Jul 23, 2023
uecasm
reviewed
Jul 24, 2023
| using var renderer = new TestRenderer( | ||
| actual.Services.GetRequiredService<IRenderedComponentActivator>(), | ||
| actual.Services.GetRequiredService<TestServiceProvider>(), | ||
| actual.Services.GetRequiredService<ILoggerFactory>()); |
There was a problem hiding this comment.
FYI you can use ActivatorUtilities.CreateInstance to create a new instance while automatically supplying existing services. Makes it less brittle if new services are needed in the future, too.
There was a problem hiding this comment.
Interesting one. I would still prefer the explicit new but a nice addition in any case.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newing up a renderer for
MarkupMatchesto prevent being deadlocked to renderer the expectedRenderFragment.