Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Internal Attributes #111 #112

Merged
merged 8 commits into from
Apr 30, 2020
Merged

Fixed Internal Attributes #111 #112

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5541b6d
Fixed Internal Attributes #111
samtrion Apr 30, 2020
a7a72e0
Fixed spacing
samtrion Apr 30, 2020
5bd5a25
Fixed spacing, second try
samtrion Apr 30, 2020
a45d375
I'm so sorry, please squash
samtrion Apr 30, 2020
ab37844
Update src/bunit.web/Rendering/Internal/Htmlizer.cs
samtrion Apr 30, 2020
4c6fdae
Added theory for handling internal attributes
samtrion Apr 30, 2020
c4623f3
Added explanation
samtrion Apr 30, 2020
5c6d3c9
Added test, which confirms correctly prefixed attributes
samtrion Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/bunit.web/Rendering/Internal/Htmlizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ internal class Htmlizer
"area", "base", "br", "col", "embed", "hr", "img", "input", "link", "meta", "param", "source", "track", "wbr"
};

private const string BLAZOR_INTERNAL_ATTR_PREFIX = "__internal_";

public const string BLAZOR_ATTR_PREFIX = "blazor:";
public const string ELEMENT_REFERENCE_ATTR_NAME = BLAZOR_ATTR_PREFIX + "elementreference";

Expand Down Expand Up @@ -222,6 +224,13 @@ private static int RenderAttributes(
{
case bool flag when flag:
result.Add(" ");
if (frame.AttributeName.StartsWith(BLAZOR_INTERNAL_ATTR_PREFIX, StringComparison.Ordinal))
{
// NOTE: this was added to make it more obvious
// that this is a generated/special blazor attribute
// for internal usage
result.Add(BLAZOR_ATTR_PREFIX);
}
result.Add(frame.AttributeName);
break;
samtrion marked this conversation as resolved.
Show resolved Hide resolved
case string value:
Expand Down