Merge pull request #1491 from bUnit-dev/release/v1.29

Release of new minor version v1.29

.devcontainer/devcontainer.json

@@ -0,0 +1,33 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/dotnet
+{
+	"name": "Full",
+	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	"image": "mcr.microsoft.com/dotnet/sdk:9.0-preview",
+	"features": {
+		"ghcr.io/devcontainers/features/dotnet:2": {
+			"version": "latest",
+			"additionalVersions": "6.0,5.0,3.1"
+		}
+	},
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Configure tool-specific properties.
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"ms-dotnettools.csdevkit",
+        		"yzhang.markdown-all-in-one",
+				"vscode-icons-team.vscode-icons",
+				"me-dutour-mathieu.vscode-github-actions"
+			]
+		}
+	},
+
+	"postCreateCommand": "bash .devcontainer/post-install.sh"
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}

.devcontainer/post-install.sh

@@ -0,0 +1,7 @@
+#/bin/bash
+
+# Install docfx (should be aligned with docs-deploy.yml)
+dotnet tool install --global docfx --version 2.74.1
+
+# Trust dotnet developer certs
+dotnet dev-certs https --check --trust

.github/workflows/ci.yml

@@ -116,7 +116,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-13, windows-latest]
     runs-on: ${{ matrix.os }}
 
     steps:
@@ -137,7 +137,7 @@ jobs:
             9.0.x
 
       - name: 🧪 Run unit tests
-        run: dotnet test -c release --blame --blame-crash --blame-hang
+        run: dotnet test -c release -p:VSTestUseMSBuildOutput=false
 
       - name: 📛 Upload hang- and crash-dumps on test failure
         if: failure()
@@ -231,7 +231,7 @@ jobs:
         run: dotnet build -c release
 
       - name: 🧪 Run sample unit tests
-        run: dotnet test docs/samples/samples.sln
+        run: dotnet test docs/samples/samples.sln -p:VSTestUseMSBuildOutput=false -f net8.0
 
       - name: 📄 Build docs
         working-directory: ./docs/site

.github/workflows/docs-deploy.yml

@@ -122,7 +122,7 @@ jobs:
 
       - name: ⏭ Create pull request from stable to main when direct merge fails
         if: steps.mergeMainline.outcome == 'failure'
-        uses: thomaseizinger/create-pull-request@1.3.1
+        uses: thomaseizinger/create-pull-request@1.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.BUNIT_BOT_TOKEN }}
         with:

.github/workflows/prepare-release.yml

@@ -84,7 +84,7 @@ jobs:
         run: git push origin release/v$NBGV_MajorMinorVersion
 
       - name: ⏭ Create pull request for release branch
-        uses: thomaseizinger/create-pull-request@1.3.1
+        uses: thomaseizinger/create-pull-request@1.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.BUNIT_BOT_TOKEN }}
         with:

.github/workflows/rebase-v2-on-main.yml

@@ -47,7 +47,7 @@ jobs:
 
       - name: ⏭ Create pull request
         if: steps.rebaseV2.outcome == 'failure'
-        uses: thomaseizinger/create-pull-request@1.3.1
+        uses: thomaseizinger/create-pull-request@1.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.BUNIT_BOT_TOKEN }}
         with:

.github/workflows/release.yml

@@ -132,7 +132,7 @@ jobs:
 
       - name: ⏭ Create pull request from stable to main when direct merge fails
         if: steps.mergeMainline.outcome == 'failure'
-        uses: thomaseizinger/create-pull-request@1.3.1
+        uses: thomaseizinger/create-pull-request@1.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.BUNIT_BOT_TOKEN }}
         with:

.gitignore

@@ -26,7 +26,6 @@ bld/
 
 # Visual Studio 2015/2017 cache/options directory
 .vs/
-.vscode/
 # Uncomment if you have tasks that create the project's static files in wwwroot
 #wwwroot/
 

.vscode/tasks.json

@@ -0,0 +1,22 @@
+{
+    // See https://go.microsoft.com/fwlink/?LinkId=733558
+    // for the documentation about the tasks.json format
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "Serve Docs (Without Build)",
+            "type": "shell",
+            "command": "docfx metadata docs/site/docfx.json && docfx docs/site/docfx.json --serve"
+        },
+        {
+            "label": "Serve Docs (With Build for API Documentation)",
+            "type": "shell",
+            "command": "dotnet build -c Release && docfx metadata docs/site/docfx.json && docfx docs/site/docfx.json --serve"
+        },
+        {
+            "label": "Run all tests (Release Mode)",
+            "type": "shell",
+            "command": "dotnet test -c Release"
+        }
+    ]
+}

CHANGELOG.md

@@ -6,6 +6,10 @@ All notable changes to **bUnit** will be documented in this file. The project ad
 
 ## [Unreleased]
 
+### Fixed
+
+- CI build changes to force running verification on x64 based AMD CPUs.
+
 ## [1.28.9] - 2024-04-19
 
 ### Fixed

CONTRIBUTING.md

@@ -24,6 +24,13 @@ Here are some resources to help you get started on how to contribute code or new
 * ["Help wanted" issues](https://github.com/egil/bunit/labels/help%20wanted) - these issues are up for grabs if you want to create a fix. To do this, simply comment on the issue you want to fix.
 * ["Good first issue" issues](https://github.com/egil/bunit/labels/good%20first%20issue) - these are good for newcomers. Good first issues are small, usually require just a few hours of work, and do not require a deep technical knowledge of bUnit. This is a good place to start if you want to become familiar with bUnit’s inner workings and maybe take on bigger issues later.
 
+### Using Codespaces
+
+bUnit offers predefined Codespaces to enable contributing to the project without having to set up a local development environment. 
+The Codespace is pre-configured with the necessary tools and dependencies to build and run the project including the .NET SDK but also serves the documentation site.
+
+[![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/bUnit-dev/bUnit?quickstart=1)
+
 ### Identifying the Scale of a Contribution
 
 If you would like to contribute to bUnit, first identify the scale of what you would like to contribute. If it is small (grammar/spelling or a bug fix), feel free to start working on a fix. If you are submitting a feature or substantial code contribution, please discuss it with us first. 

Directory.Build.props

@@ -52,7 +52,7 @@
 	<!-- Shared code analyzers used for all projects in the solution -->
 	<ItemGroup Label="Code Analyzers">
 		<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="9.23.1.88495" PrivateAssets="All" />
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="9.26.0.92422" PrivateAssets="All" />
 	</ItemGroup>
 
 	<ItemGroup Label="Implicit usings"

src/Directory.Build.props

@@ -63,7 +63,7 @@ See the full changelog at https://github.com/bUnit-dev/bUnit/releases
 
 	<ItemGroup>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
-		<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" PrivateAssets="All" />
+		<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.139" PrivateAssets="All" />
 	</ItemGroup>
 
 </Project>

src/bunit.core/TestContextBase.cs

@@ -106,7 +106,9 @@ protected virtual void Dispose(bool disposing)
 
 		// The service provider should dispose of any
 		// disposable object it has created, when it is disposed.
+#pragma warning disable S3966 // On purpose to dispose synchronously and asynchronously
 		Services.Dispose();
+#pragma warning restore S3966
 	}
 
 	/// <summary>

src/bunit.generators.internal/bunit.generators.internal.csproj

@@ -15,13 +15,13 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="AngleSharp" Version="1.1.1" />
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.9.2" />
+		<PackageReference Include="AngleSharp" Version="1.1.2" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.10.0" />
 		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
-		<PackageReference Include="Meziantou.Polyfill" Version="1.0.37">
+		<PackageReference Include="Meziantou.Polyfill" Version="1.0.39">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
 		</PackageReference>

src/bunit.generators/bunit.generators.csproj

@@ -70,16 +70,16 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.9.2" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.10.0" />
 		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
-		<PackageReference Include="Meziantou.Polyfill" Version="1.0.37">
+		<PackageReference Include="Meziantou.Polyfill" Version="1.0.39">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
-		<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" PrivateAssets="All" />
+		<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.139" PrivateAssets="All" />
 	</ItemGroup>
 </Project>

src/bunit.template/template/Company.BlazorTests1.csproj

@@ -17,7 +17,7 @@
 
 	<ItemGroup>
 		<PackageReference Include="bunit" Version="#{RELEASE_VERSION}#" />
-		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
 		<PackageReference Include="coverlet.collector" Version="6.0.0">
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 			<PrivateAssets>all</PrivateAssets>

src/bunit.web.query/bunit.web.query.csproj

@@ -18,7 +18,7 @@
 		<PackageReference Include="Microsoft.Extensions.Logging" Version="$(DotNet3Version)" />
 		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="$(DotNet3Version)" />
 		<PackageReference Include="Microsoft.AspNetCore.Components" Version="$(DotNet3Version)" />
-		<PackageReference Include="Meziantou.Polyfill" Version="1.0.37">
+		<PackageReference Include="Meziantou.Polyfill" Version="1.0.38">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
 		</PackageReference>

src/bunit.web/bunit.web.csproj

@@ -44,7 +44,7 @@
 	</ItemGroup>
 
 	<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
-		<PackageReference Include="AngleSharp" Version="1.1.1" />
+		<PackageReference Include="AngleSharp" Version="1.1.2" />
 		<PackageReference Include="AngleSharp.Css" Version="1.0.0-beta.139" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.Authorization" Version="$(DotNet6Version)" />
 		<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet6Version)" />
@@ -55,7 +55,7 @@
 	</ItemGroup>
 
 	<ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
-		<PackageReference Include="AngleSharp" Version="1.1.1" />
+		<PackageReference Include="AngleSharp" Version="1.1.2" />
 		<PackageReference Include="AngleSharp.Css" Version="1.0.0-beta.139" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.Authorization" Version="$(DotNet7Version)" />
 		<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet7Version)" />
@@ -66,7 +66,7 @@
 	</ItemGroup>
 
 	<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
-		<PackageReference Include="AngleSharp" Version="1.1.1" />
+		<PackageReference Include="AngleSharp" Version="1.1.2" />
 		<PackageReference Include="AngleSharp.Css" Version="1.0.0-beta.139" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.Authorization" Version="$(DotNet8Version)" />
 		<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet8Version)" />
@@ -77,7 +77,7 @@
 	</ItemGroup>
 
 	<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
-		<PackageReference Include="AngleSharp" Version="1.1.1" />
+		<PackageReference Include="AngleSharp" Version="1.1.2" />
 		<PackageReference Include="AngleSharp.Css" Version="1.0.0-beta.139" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.Authorization" Version="$(DotNet9Version)" />
 		<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet9Version)" />

tests/.editorconfig

@@ -48,3 +48,4 @@ dotnet_diagnostic.xUnit1034.severity = none			# xUnit1034: Null should not be us
 dotnet_diagnostic.S1144.severity = suggestion		# S1144: Unused private types or members should be removed
 dotnet_diagnostic.S2094.severity = suggestion		# S2094: Classes should not be empty
 dotnet_diagnostic.S6562.severity = suggestion		# "Provide the "DateTimeKind" when creating this object.
+dotnet_diagnostic.S6966.severity = suggestion		# S6966: Await method instead

tests/Directory.Build.props

@@ -17,10 +17,10 @@
 	<ItemGroup>
 		<PackageReference Include="AutoFixture" Version="4.18.1" />
 		<PackageReference Include="AutoFixture.Xunit2" Version="4.18.1" />
-		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
 		<PackageReference Include="NSubstitute" Version="5.1.0" />
 		<PackageReference Include="Shouldly" Version="4.2.1" />
-		<PackageReference Include="coverlet.msbuild" Version="6.0.1" PrivateAssets="All" />
+		<PackageReference Include="coverlet.msbuild" Version="6.0.2" PrivateAssets="All" />
 		<PackageReference Include="Xunit.Combinatorial" Version="1.6.24" />
 	</ItemGroup>
 

tests/bunit.core.tests/bunit.core.tests.csproj

@@ -13,7 +13,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="xunit" Version="2.7.0" />
+		<PackageReference Include="xunit" Version="2.8.1" />
 		<!-- DO NOT UPGRADE TO versions > 2.4.5 as they do not support .net5 or older -->
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
 			<PrivateAssets>all</PrivateAssets>

tests/bunit.generators.tests/bunit.generators.tests.csproj

@@ -13,19 +13,19 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
 		<PackageReference Include="System.Net.Http" Version="4.3.4" />
 		<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
 		<PackageReference Include="Verify.SourceGenerators" Version="2.2.0" />
-		<PackageReference Include="Verify.Xunit" Version="23.7.2" />
+		<PackageReference Include="Verify.Xunit" Version="25.3.0" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="8.0.2" />
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.9.2" />
-		<PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.9.2" />
-		<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.9.2" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.10.0" />
+		<PackageReference Include="Microsoft.CodeAnalysis.Common" Version="4.10.0" />
+		<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.10.0" />
 		<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.9.2" />
 		<PackageReference Update="Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing.XUnit" Version="1.1.1" />
 
-		<PackageReference Include="xunit" Version="2.7.0" />
+		<PackageReference Include="xunit" Version="2.8.1" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

tests/bunit.testassets/bunit.testassets.csproj

@@ -14,18 +14,18 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Serilog" Version="3.1.1" />
+		<PackageReference Include="Serilog" Version="4.0.0" />
 		<PackageReference Include="Serilog.Expressions" Version="4.0.0" />
-		<PackageReference Include="xunit.extensibility.execution" Version="2.7.0" />
+		<PackageReference Include="xunit.extensibility.execution" Version="2.8.1" />
 		<PackageReference Include="xunit.abstractions" Version="2.0.3" />		
-		<PackageReference Include="xunit.assert" Version="2.7.0" />
+		<PackageReference Include="xunit.assert" Version="2.8.1" />
 	</ItemGroup>
 
 	<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.1'">
 		<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" Version="$(DotNet3Version)" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="3.2.1" />
 		<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Authentication" Version="3.2.1" />
-		<PackageReference Include="System.Text.Json" Version="8.0.2" />
+		<PackageReference Include="System.Text.Json" Version="8.0.3" />
 		<PackageReference Include="Serilog.Extensions.Logging" Version="8.0.0" />
 	</ItemGroup>
 	<ItemGroup Condition="'$(TargetFramework)' == 'net5.0'">

tests/bunit.web.query.tests/bunit.web.query.tests.csproj

@@ -14,7 +14,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="xunit" Version="2.7.0" />
+		<PackageReference Include="xunit" Version="2.8.1" />
 		<!-- DO NOT UPGRADE TO versions > 2.4.5 as they do not support .net5 or older -->
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
 			<PrivateAssets>all</PrivateAssets>

tests/bunit.web.tests/bunit.web.tests.csproj

@@ -13,7 +13,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="xunit" Version="2.7.0" />
+		<PackageReference Include="xunit" Version="2.8.1" />
 		<!-- DO NOT UPGRADE TO versions > 2.4.5 as they do not support .net5 or older -->
 		<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
 			<PrivateAssets>all</PrivateAssets>

version.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "1.28",
+  "version": "1.29",
   "assemblyVersion": {
     "precision": "revision"
   },