Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Modifications #1

Merged
merged 20 commits into from
Jul 20, 2015
Merged

Various Modifications #1

merged 20 commits into from
Jul 20, 2015

Conversation

jaydg
Copy link
Contributor

@jaydg jaydg commented Jul 17, 2015

  • Examples can now be run from the source tree without the gem installed
  • Various cleanups, e.g.
    • whitespace
    • spelling
    • moved all classes to the RuTui module (re-indent of all classes)
  • Switch to IO.Console (Ruby 1.8 and 1.9 are obsoleted since quite a while now)
  • Vastly improved input: control keys and function keys are translated to symbols
  • Completely removed dependency to external utilities

To be done: Verify the changes work on Windows and add key translation for Windows

@b1nary
Copy link
Owner

b1nary commented Jul 20, 2015

Hey there, awesome pull request, kudos! I havent even heard about console/io and its features, i assume this makes it much easier to support windows properly. I had some reason for the escape code, but i can't remember so i'll test it in a sec on my boxes and merge then.

Sorrily i also dont have windows available currently, i will forward this ASAP.

@b1nary
Copy link
Owner

b1nary commented Jul 20, 2015

the escaping breaks for me in bash on linux, but i am sure i'll figure that out.

You are on a mac i assume?

Anyway, i'll check/fix that later.

b1nary added a commit that referenced this pull request Jul 20, 2015
Various Modifications
@b1nary b1nary merged commit 7053d4b into b1nary:master Jul 20, 2015
@b1nary
Copy link
Owner

b1nary commented Jul 20, 2015

my fail, it was a problem in the static object rendering. Your pushes work great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants