possibly incorrect migration of dam_pages (migraterelations)

[dneuge]

While rewriting caption/title/alt handling for images I noticed that migraterelations may query for tt_content.uid using a page ID (tx_dam_mm_ref.uid_foreign when tx_dam_mm_ref.tablenames is pages or pages_language_overlay), then uses the result as captions. This does seem wrong unless I'm missing something. According to history, this was introduced for migration of dam_pages extension providing file ("media") references on page properties and should only be effective for $insertData['fieldname'] === 'media' (mapped field name according to getColForFieldName). As it appears to query the wrong table for metadata, however, it may never have worked.

Merging pull request #74 will limit image metadata processing to tt_content, media metadata is still queried the same way as before but now has a comment with a reference to this issue.

Edit: Column mapping for dam_pages is of course media, not image. Changed fieldname above.

[dneuge]

Closing this issue as the pull request has been merged.