Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix incoming record being overwritten from DB, stringify pieces #37

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

fwg
Copy link
Contributor

@fwg fwg commented Dec 5, 2023

This fixes #33 by applying array_replace to the loaded record array with the incoming record fields.

Also apply string casting to the slug pieces to avoid fatal error when some other hook sets a record field as something else than string, e.g. integer.

This fixes b13#33 by applying array_replace to the loaded record array
with the incoming record fields.

Also apply string casting to the slug pieces to avoid fatal error when
some other hook sets a record field as something else than string, e.g.
integer.
@bmack bmack merged commit a5a6b85 into b13:master Dec 5, 2023
@fwg fwg mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlugModifier ignores unsaved record data received through XHR
2 participants