Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch L-1 #7

Merged
merged 1 commit into from
Jul 12, 2024
Merged

patch L-1 #7

merged 1 commit into from
Jul 12, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 3, 2024

Closes: L-1

Description

L-1

Usage of deprecated WrapSDKContext()

  • removed deprecated sdk.WrapSDKContext()

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 requested a review from poorphd July 3, 2024 03:04
@dudong2 dudong2 self-assigned this Jul 3, 2024
Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 marked this pull request as ready for review July 4, 2024 09:15
@dudong2 dudong2 requested review from dongsam and zsystm July 9, 2024 14:50
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit ec14414 into canto-v8/develop Jul 12, 2024
14 of 22 checks passed
@dudong2 dudong2 deleted the patch/issue-L-1 branch July 12, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants