Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zero gas fee poc #29

Draft
wants to merge 1 commit into
base: basechain/develop
Choose a base branch
from
Draft

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Dec 5, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dongsam
Copy link
Member

dongsam commented Dec 6, 2024

LGTM and sufficient and well-designed as a PoC

  • Currently, zero-fee registration is allowed for specific Contract * Signature, but if restrictions could also be applied to the from address, it would enhance spam prevention by enabling zero-fee application for Contract * Signature * from_address combinations
  • Once the requirements and use case details are finalized, it can be determined whether from address validation needs to be included, and the implementation can then be refined for production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants