Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump cosmos-sdk v0.45.16 and cometbft v0.34.33 #16

Merged
merged 23 commits into from
Aug 19, 2024
Merged

feat: Bump cosmos-sdk v0.45.16 and cometbft v0.34.33 #16

merged 23 commits into from
Aug 19, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 7, 2024 •
edited
Loading

Closes: #XXX

Description

  • dependencies
    • go v1.21
    • cosmos-sdk v0.45.16
    • cometbft(tendermint) v0.34.33

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Aug 7, 2024
@dudong2 dudong2 changed the title Patch/bump cosmossdk v0.45.16 cometbft v0.34.33 feat: Bump cosmossdk v0.45.16 and cometbft v0.34.33 Aug 7, 2024
@dudong2 dudong2 changed the title feat: Bump cosmossdk v0.45.16 and cometbft v0.34.33 feat: Bump cosmos-sdk v0.45.16 and cometbft v0.34.33 Aug 7, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
client/keys/add.go Fixed Show fixed Hide fixed
@dudong2 dudong2 marked this pull request as ready for review August 8, 2024 16:34
@dongsam
Copy link
Member

dongsam commented Aug 9, 2024

I would appreciate it if you could add a reviewer when the PR reaches the R4R stage so that they can receive a notification.

@dongsam dongsam requested review from jasonsong0 and zsystm August 9, 2024 01:23
zsystm
zsystm reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some minor things.
And I left some questions about nix.

  • How can I run nix tests in my local?
    It would be appreciate if you share any guide link (e.g. notion)

.github/workflows/test.yml Outdated Show resolved Hide resolved
nix/default.nix Show resolved Hide resolved
nix/go-ethereum.nix Show resolved Hide resolved
nix/sources.json Show resolved Hide resolved
nix/testenv.nix Show resolved Hide resolved
@dudong2
Copy link
Collaborator Author

dudong2 commented Aug 9, 2024 •
edited
Loading

LGTM, except some minor things. And I left some questions about nix.

  • How can I run nix tests in my local?
    It would be appreciate if you share any guide link (e.g. notion)

Before all, you need to install nixos(ref. https://nixos.org/download/)
And just type make run-integration-tests to your terminal, then it will work.

I'll write a notion about nix in the near future.

@dudong2 dudong2 requested a review from zsystm August 9, 2024 04:30
@dongsam
Copy link
Member

dongsam commented Aug 13, 2024

@jasonsong0 Could you review this PR? This is a blocker for https://github.com/b-harvest/basechain/pull/14

dongsam
dongsam reviewed Aug 13, 2024
View reviewed changes
default.nix Outdated Show resolved Hide resolved
jasonsong0
jasonsong0 approved these changes Aug 13, 2024
View reviewed changes
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I left a comment, but I've never used nix at all, so if it's not relevant, just ignore it.

nix/default.nix Outdated
go-ethereum = pkgs.callPackage ./go-ethereum.nix {
inherit (pkgs.darwin) libobjc;
inherit (pkgs.darwin.apple_sdk.frameworks) IOKit;
buildGoModule = pkgs.buildGo118Module;
buildGoModule = pkgs.buildGo120Module;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If go target version is 1.21, shouldn't it be pkgs.buildGo121Module?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 1.21

nix/default.nix Outdated
(_: pkgs: {
cosmovisor = pkgs.buildGo118Module rec {
cosmovisor = pkgs.buildGo120Module rec {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use buildGo121Module?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@dongsam
Copy link
Member

dongsam commented Aug 18, 2024

@dudong2 Once the review and comments on this PR are reflected and merged, PR #14 can follow and be merged. This will help minimize conflicts in future PRs for the basechain. If it doesn't take too long, I would appreciate it if you could prioritize processing this first.

zsystm
zsystm approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit e234684 into releases/v0.19.3-hotfix Aug 19, 2024
9 checks passed
@dudong2 dudong2 deleted the patch/bump-cosmossdk-v0.45.16-cometbft-v0.34.33 branch August 19, 2024 04:06
@dongsam
Copy link
Member

dongsam commented Aug 19, 2024

@dudong2 Please release tag as v0.19.3-basechain-2 for the base branch, and then bump on https://github.com/b-harvest/basechain/pull/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsam dongsam dongsam left review comments

@zsystm zsystm zsystm approved these changes

@jasonsong0 jasonsong0 jasonsong0 approved these changes

Assignees

@dudong2 dudong2

Labels
C:CLI C:Types Type: Build Type: CI Type: Docs Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dudong2 @dongsam @jasonsong0 @zsystm