Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait-tx query cmd #14

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat: wait-tx query cmd #14

merged 1 commit into from
Jul 29, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 29, 2024

Closes: #XXX

Description

how to test

  • check both ethermintd query wait-tx and ethermintd query event-query-tx-for works

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 requested review from dongsam and zsystm July 29, 2024 07:18
@dudong2 dudong2 self-assigned this Jul 29, 2024
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 6d3c5c6 into canto-v8/develop Jul 29, 2024
17 of 24 checks passed
@dudong2 dudong2 deleted the wait-tx_cmd branch July 29, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants