Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch codec #10

Merged
merged 3 commits into from
Jul 19, 2024
Merged

patch codec #10

merged 3 commits into from
Jul 19, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 11, 2024

Closes: #XXX

Description

  • replace naming of legacy amino codec and add amino test

NOTE

  • the type of evmtypes.MsgEthereumTx.Size_ is float64 that is not supported at aminojson encoder, so I commented MsgEthereumTx test.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 11, 2024
@dudong2 dudong2 requested a review from poorphd July 11, 2024 08:39
@dudong2 dudong2 requested a review from zsystm July 11, 2024 08:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (ec14414) to head (4e65c26).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           canto-v8/develop      #10      +/-   ##
====================================================
+ Coverage             68.24%   68.30%   +0.05%     
====================================================
  Files                   116      117       +1     
  Lines                 11210    11240      +30     
====================================================
+ Hits                   7650     7677      +27     
- Misses                 3086     3088       +2     
- Partials                474      475       +1     
Files Coverage Δ
x/evm/types/codec.go 86.36% <100.00%> (+0.31%) ⬆️
x/feemarket/types/codec.go 50.00% <100.00%> (+4.54%) ⬆️
app/rapidgen.go 89.28% <89.28%> (ø)

Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 0712f94 into canto-v8/develop Jul 19, 2024
16 of 24 checks passed
@dudong2 dudong2 deleted the patch/codec branch July 19, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants