Problem: mempool.GasTx interface is not reused (cosmos#536)

* Problem: redundant mutex for InsertWithGasWanted cfg of PriorityNonceMempool remains unchanged once assigned, so no lock is required * make mocks * cleanup * keep order of check MaxTx
b-harvest · Jul 2, 2024 · 52a97a8 · 52a97a8
1 parent 36295f0
commit 52a97a8
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 27 deletions.
diff --git a/baseapp/abci_utils.go b/baseapp/abci_utils.go
@@ -271,9 +271,7 @@ func (h *DefaultProposalHandler) PrepareProposalHandler() sdk.PrepareProposalHan
 				}
 
 				var txGasLimit uint64
-				if gasTx, ok := tx.(interface {
-					GetGas() uint64
-				}); ok {
+				if gasTx, ok := tx.(mempool.GasTx); ok {
 					txGasLimit = gasTx.GetGas()
 				}
 

diff --git a/baseapp/testutil/mock/mocks.go b/baseapp/testutil/mock/mocks.go
diff --git a/x/gov/testutil/expected_keepers_mocks.go b/x/gov/testutil/expected_keepers_mocks.go