feat: remove delegator address in WrappedFilePV, change init cmd and add migration cmd.

[wnjoon]

Description

This PR changes the logic including the delegator address while removing the WrappedFilePV structure.

• Cleaned up the unused field LastSignState in the WrappedFilePV structure and reduced the hierarchy by one level.
• In babylond create-bls-key, only the bls key is generated based on the password entered as a prompt, and the delegator address is passed as an argument at the time of babylond gen-helper create-bls.
• Changed to generate priv_validator_key.json and bls key files simultaneously during babylond init.
• Removed DelegatorAddress from BlsPV struct and removed unnecessary logic to validate DelegatorAddress at ExtendVote().
• Added an error message to suggest running the init or create-bls-key commands if the key file does not exist at babylond start time. This prevents the node from starting if the key file does not exist, and restricts key files to only be created via specific cli.
• Add cmd for migration. (How to test for migration)

1. the separation feature would be inserted in a new rc release
2. validator stops the current node
3. validator download the new release
4. validator run the migration cmd
5. restart the node and voting should be resumed

• Fix e2e test 'e2e-run-upgrade-v1'
  • Added a new build tag, “e2e_upgrade”, to the image used for the e2e test 'e2e-run-upgrade-v1'.
  • When this build tag is active, the previous version’s priv_validator_key.json file is automatically migrated to the updated structure, where the comet and BLS keys are separated. This ensures compatibility with the new key file format.
  • This migration is necessary because containers for pre-upgrade versions are pulled from Docker Hub, Without this adjustment, errors occur due to the outdated key file structure not being applied in the previous version.

How to test for migration

Before starting, two different versions of babylond are required. One is the previous version and the other is the changed version.

The previous version should generate priv_validator_key.json, which contains comet and bls keys. and the changed version generates separate files saving each key.

1. Start the node using the babylond version before changing.

$ ./babylond init my-node --chain-id test-chain-1
$ ./babylond keys add validator1 --keyring-backend test
$ ./babylond add-genesis-account $(./babylond keys show validator1 -a --keyring-backend test) 2000000000000ubbn,2000000000000stake
$ ./babylond gentx validator1 1500000000000stake --chain-id test-chain-1 --keyring-backend test --fees 400ubbn
$ ./babylond collect-gentxs
$ ./babylond create-bls-key 
$ ./babylond gen-helpers create-bls $(./babylond keys show validator1 -a --keyring-backend test)
# copy content of gen-bls-x.json into checkpointing.genesis_keys field in genesis.json
$ ./babylond start

2. Stop the running node.

3. Execute migration from the changed version of babylond.

Before calling migration, check if the priv_validator_key.json file storing the two types of keys exists inside <home>/.babylond/config.

$ ./babylond migrate

4. Enter the password you will use to encrypt the bls key into the erc2335 structure.

5. Verify that the bls_key.json and bls_password.txt files are correctly created in <home>/.babylond/config.

6. Verify that priv_validator_key.json contains only keys for comet.

7. Restart the node using changed version of babylond.

$ ./babylond start

Error cases

• If priv_validator_key.json does not exist when calling migration
• If priv_validator_key.json does not satisfy the previous version of a structure containing comet and bls keys.

[wnjoon]

Commit Summary

fd5e873

• Recreate the WrappedFilePV structure with unnecessary fields removed.
• Change BlsSigner interface implementation back to WrappedFilePV.

946eab5

• Add and test InitCmd function that wraps cosmos' InitCmd.
• Use the function used in create-bls-key to generate a bls key.

57ddd51

• Remove DelegatorAddress validation when calling ExtendVote function

280de7e

• Check if key file exists in InitPrivSigner when starting node and output action message

[dongsam]

Consider Removing GetValidatorPubkey and FilePVKey

• If the BLS ValidatorPubkey exists, we can retrieve the associated ValidatorAddr through its pairing (via blsKeysToAddr).
• This would eliminate the need for GetValidatorPubkey.
• Consequently, the FilePVKey from Comet in WrappedFilePV would also become unnecessary and could be removed.
• Removing FilePVKey would reduce overall complexity.

Observations

• Reading FilePVKey at the app level seems unnatural.
• In cases where CometBFT uses a PrivValidator that does not rely on FilePV (e.g., Horcrux, tmkms or other SignerClient), FilePV will not exist.
• Without FilePV, it may not be possible to perform vote extensions.

Benefits of Removing FilePV

• Simplifies the architecture by removing dependency on FilePVKey.
• Aligns better with modern PrivValidator implementations that utilize external signing solutions like Horcrux.

[dongsam]

@wnjoon The base branch of this PR currently overlaps with the branch for #396. To prevent branches from different PRs from mixing, please fetch https://github.com/babylonlabs-io/babylon/tree/feat/bls-keystore-improvement into the b-harvest repository and update the base branch of this PR

[dongsam]

@wnjoon Could you add plan on description for migration cmd?

1. the separation feature would be inserted in a new rc release
2. validator stops the current node
3. validator download the new release
4. validator run the migration cmd
5. restart the node and voting should be resumed

[wnjoon]

Commit Summary

cd6ffcf

• Add migration cmd

[wnjoon]

Commit Summary

4e41051

• Change cmd to migrate0bls-key
• Add verification to check previous keys are equal to keys in new files
• Add a NOTE to back up previously used key files

[wnjoon]

Commit Summary

d055b84

• Modify migration logic (save files after verification)
• Add password prompt (missed)
• Add test case to verify new file after migration