Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Package bump from v7 to v8 #86

Merged
merged 4 commits into from
Aug 2, 2024
Merged

refactor: Package bump from v7 to v8 #86

merged 4 commits into from
Aug 2, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Aug 2, 2024

Description

  • package bump from v7 to v8

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Aug 2, 2024
@dudong2 dudong2 requested review from zsystm, poorphd and dongsam August 2, 2024 03:09
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • Build and run works.
  • No v7 in the code except upgrade related codes.
  • Just to be sure, I also checked the v6 --> v7 bump PR, and everything seems fine.

@dudong2 dudong2 marked this pull request as ready for review August 2, 2024 06:49
@dudong2 dudong2 merged commit 7986a6f into v8/develop Aug 2, 2024
8 checks passed
@dongsam dongsam changed the title feat: Package bump from v7 to v8 refactor: Package bump from v7 to v8 Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants