Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cli pagination cmd to query "cantod q csr csrs" #72

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jul 18, 2024

Description

  • fixes an issue where the pagination flag was not present in the csrs query, making it impossible to query for all csrs.

how to test

  • pagination flag must be available in the csrs query
  • eg. cantod query csr csrs --page 3, cantod query csr csrs --offset 333 --limit 99, ...

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jul 18, 2024
@dudong2 dudong2 requested review from dongsam, zsystm and poorphd July 18, 2024 18:07
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 724d674 into v8/develop Jul 19, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/csr-pagination branch July 19, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants