Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch/coinswap,src,inflation,onboarding #64

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jul 8, 2024

Description

  • rename codec naming for legacy amino

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jul 8, 2024
@dudong2 dudong2 requested a review from poorphd July 9, 2024 07:33
Copy link

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 requested review from dongsam and zsystm July 10, 2024 14:14
@dudong2 dudong2 marked this pull request as ready for review July 10, 2024 14:19
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dudong2 dudong2 merged commit 5b9e51a into v8/develop Jul 11, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/coinswap,src,inflation,onboarding branch July 11, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants