Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CustomGetSigners for MsgSwapOrder #62

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Conversation

poorphd
Copy link

@poorphd poorphd commented Jul 3, 2024

Description

Cosmos SDK v0.50 this method has been dropped and replaced with the declarative cosmos.msg.v1.signer protobuf tag.
For MsgSwapOrder, which does not have a cosmos.msg.v1.signer to
resolve the signer, custom GetSigners function is defined.

Closes: code-423n4/2024-05-canto-findings#27


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@poorphd poorphd self-assigned this Jul 3, 2024
@poorphd poorphd requested a review from dudong2 July 3, 2024 10:56
app/app.go Outdated Show resolved Hide resolved
x/coinswap/types/msgs.go Outdated Show resolved Hide resolved
Copy link

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poorphd poorphd marked this pull request as ready for review July 9, 2024 07:31
@poorphd poorphd requested review from dongsam and zsystm July 9, 2024 07:32
x/coinswap/types/msgs.go Outdated Show resolved Hide resolved
@poorphd poorphd merged commit 3a78be0 into v8/develop Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsgSwapOrder will never work for Canto nodes
3 participants