refactor: Replace deprecated simapp.MakeTestEncodingConfig with moduletestutil.MakeTestEncodingConfig #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etestutil.MakeTestEncodingConfig The simapp.MakeTestEncodingConfig function has been deprecated and removed. Updated the tests to use moduletestutil.MakeTestEncodingConfig instead, which requires a series of relevant AppModuleBasic as input, including the module being tested and any potential dependencies. This change ensures that the test configuration is up-to-date and compatible with the latest SDK standards.
dudong2
approved these changes
Jul 2, 2024
dongsam
reviewed
Jul 9, 2024
| @@ -174,7 +174,7 @@ func SimulateMsgAddLiquidity(k keeper.Keeper, ak types.AccountKeeper, bk types.B | |||
| } | |||
| } | |||
|
|
|||
| txGen := simappparams.MakeTestEncodingConfig().TxConfig | |||
| txGen := moduletestutil.MakeTestEncodingConfig().TxConfig | |||
There was a problem hiding this comment.
Have there been any issues arising from the TestEncodingConfig not registering the interfaces of custom modules like coinswap? Please check if there are any problems, and if so, it would be good to refactor this code to use the same encoding config for tests and simulations as well.
There was a problem hiding this comment.
Using TestEncodingConfig, even if we do not pass modules, the msg will be recognized and reach the msg server.
gogoProtoRegistry.FindDescriptorByName(name) already contains the custom module's proto. descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The simapp.MakeTestEncodingConfig function has been deprecated and removed. Updated the tests to use moduletestutil.MakeTestEncodingConfig instead, which requires a series of relevant AppModuleBasic as input, including the module being tested and any potential dependencies. This change ensures that the test configuration is up-to-date and compatible with the latest SDK standards.
Closes: L-3
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...