Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x #53

Merged
merged 98 commits into from
Jul 1, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Feb 22, 2024

Description

Closes: #XXXX

Key dependency changes:

  • Cosmos-SDK v0.45.9 to v0.50.6
  • CometBFT (Tendermint) v0.34.25 to v0.38.6
  • ibc-go v3.2.0 to v8.2.1
  • go-ethereum v1.10.19 to v1.10.26

notable changed files

app/app.go
app/ante/ante.go
app/ante/handler_options.go
app/upgrades/v8/upgrades.go
x/csr/keeper/keeper.go
x/csr/keeper/msg_server.go
x/csr/module.go
x/erc20/keeper/keeper.go
x/erc20/keeper/msg_server.go
x/erc20/module.go
x/govshuttle/keeper/keeper.go
x/govshuttle/keeper/msg_server.go
x/govshuttle/module.go
x/epochs/keeper/keeper.go
x/epochs/keeper/abci.go
x/epochs/module.go
x/inflation/keeper/keeper.go
x/inflation/keeper/hooks.go
x/inflation/module.go
x/coinswap/keeper/keeper.go
x/coinswap/keeper/msg_server.go
x/coinswap/module.go
x/onboarding/ibc_middleware.go
x/onboarding/keeper/keeper.go
x/onboarding/keeper/msg_server.go
x/onboarding/keeper/ibc_callbacks.go
x/onboarding/module.go

app

modules

NOTE

  • v8 package bump will be done in a separate pr after this pr is merged to avoid amplification of file changes in that pr
  • x/onboarding module is a feature-driven of the ibc. So, need to ensure that features don't behave differently compared to canto v7, as the version of the ibc-go bump up.
  • as the versions of different modules in go.mod are upgraded, need to ensure that there are no security issues.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

dudong2 and others added 30 commits December 4, 2023 12:32
change ethermint to Canto-Network/ethermint which includes Canto-Network/ethermint#1 (comment)
update ethermint dependecny to hotfix version
@dudong2 dudong2 changed the base branch from main to package-v7-to-v8-bump May 10, 2024 05:08
@dongsam
Copy link
Member

dongsam commented Jul 1, 2024

Based on the changes in this PR, an audit was conducted, and issues were found. To manage these issues with separate patch PRs, we will merge this PR even though it is not yet perfect.

@dongsam dongsam merged commit 868b183 into package-v7-to-v8-bump Jul 1, 2024
8 checks passed
@dudong2 dudong2 mentioned this pull request Jul 26, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants