forked from Canto-Network/Canto
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x #53
Merged
dongsam
merged 98 commits into
package-v7-to-v8-bump
from
dudong2/feat/[email protected]
Jul 1, 2024
Merged
feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x #53
dongsam
merged 98 commits into
package-v7-to-v8-bump
from
dudong2/feat/[email protected]
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change ethermint to Canto-Network/ethermint which includes Canto-Network/ethermint#1 (comment)
update ethermint dependecny to hotfix version
…ate to upgrade handler
This reverts commit fad4908.
This was referenced May 21, 2024
Based on the changes in this PR, an audit was conducted, and issues were found. To manage these issues with separate patch PRs, we will merge this PR even though it is not yet perfect. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Key dependency changes:
notable changed files
app
modules
ValidateBasic
logic to msg_serverprotobuf
. But in case ofMsgConvertERC20
, GetSigners func is alive and implemented GetSignersFromMsgConvertERC20V2 func additionally.(ref. feat: bump up cosmos-sdk v0.50.x, cometbft v0.38.x #53 (comment))msg level
soauthority
has been added to the required module.(ref. Add CLI command to submit new Gov proposals, using Msgs cosmos/cosmos-sdk#10952)KVStoreService
as opposed to the prev way of accessing KVStore via store key.(ref. refactor(x/staking)!: KVStoreService, return errors and use context.Context cosmos/cosmos-sdk#16324, ...)NOTE
v8 package bump
will be done in a separate pr after this pr is merged to avoid amplification of file changes in that prx/onboarding
module is a feature-driven of theibc
. So, need to ensure that features don't behave differently compared to canto v7, as the version of theibc-go
bump up.go.mod
are upgraded, need to ensure that there are no security issues.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...