issue fix (Azure#26379)

Azure#26371
azure-sdk · Jul 5, 2023 · f725fd6 · f725fd6
1 parent 775ebff
commit f725fd6
Show file tree

Hide file tree

Showing 5 changed files with 58 additions and 5 deletions.
diff --git a/sdk/selfhelp/arm-selfhelp/assets.json b/sdk/selfhelp/arm-selfhelp/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "js",
   "TagPrefix": "js/selfhelp/arm-selfhelp",
-  "Tag": "js/selfhelp/arm-selfhelp_05d2b1877d"
+  "Tag": "js/selfhelp/arm-selfhelp_4ad1653c50"
 }
diff --git a/sdk/selfhelp/arm-selfhelp/samples-dev/diagnosticsCreateSample.ts b/sdk/selfhelp/arm-selfhelp/samples-dev/diagnosticsCreateSample.ts
@@ -26,9 +26,19 @@ async function createsADiagnosticForAKeyVaultResource() {
   const diagnosticsResourceName = "VMNotWorkingInsight";
   const credential = new DefaultAzureCredential();
   const client = new HelpRP(credential);
+  const options = {
+    diagnosticResourceRequest: {
+      insights: [
+        {
+          solutionId: "KeyVaultUnauthorizedNetworkInsight"
+        }
+      ]
+    }
+  }
   const result = await client.diagnostics.beginCreateAndWait(
     scope,
-    diagnosticsResourceName
+    diagnosticsResourceName,
+    options
   );
   console.log(result);
 }

diff --git a/sdk/selfhelp/arm-selfhelp/samples/v1/javascript/diagnosticsCreateSample.js b/sdk/selfhelp/arm-selfhelp/samples/v1/javascript/diagnosticsCreateSample.js
@@ -24,7 +24,20 @@ async function createsADiagnosticForAKeyVaultResource() {
   const diagnosticsResourceName = "VMNotWorkingInsight";
   const credential = new DefaultAzureCredential();
   const client = new HelpRP(credential);
-  const result = await client.diagnostics.beginCreateAndWait(scope, diagnosticsResourceName);
+  const options = {
+    diagnosticResourceRequest: {
+      insights: [
+        {
+          solutionId: "KeyVaultUnauthorizedNetworkInsight",
+        },
+      ],
+    },
+  };
+  const result = await client.diagnostics.beginCreateAndWait(
+    scope,
+    diagnosticsResourceName,
+    options
+  );
   console.log(result);
 }
 

diff --git a/sdk/selfhelp/arm-selfhelp/samples/v1/typescript/src/diagnosticsCreateSample.ts b/sdk/selfhelp/arm-selfhelp/samples/v1/typescript/src/diagnosticsCreateSample.ts
@@ -26,9 +26,19 @@ async function createsADiagnosticForAKeyVaultResource() {
   const diagnosticsResourceName = "VMNotWorkingInsight";
   const credential = new DefaultAzureCredential();
   const client = new HelpRP(credential);
+  const options = {
+    diagnosticResourceRequest: {
+      insights: [
+        {
+          solutionId: "KeyVaultUnauthorizedNetworkInsight"
+        }
+      ]
+    }
+  }
   const result = await client.diagnostics.beginCreateAndWait(
     scope,
-    diagnosticsResourceName
+    diagnosticsResourceName,
+    options
   );
   console.log(result);
 }

diff --git a/sdk/selfhelp/arm-selfhelp/test/selfhelp_operations_test.spec.ts b/sdk/selfhelp/arm-selfhelp/test/selfhelp_operations_test.spec.ts
@@ -41,6 +41,7 @@ describe("help test", () => {
   let resourceGroup: string;
   let resourcename: string;
   let scope: string;
+  let scope1: string;
 
   beforeEach(async function (this: Context) {
     recorder = new Recorder(this.currentTest);
@@ -51,8 +52,9 @@ describe("help test", () => {
     client = new HelpRP(credential, recorder.configureClientOptions({}));
     location = "eastus";
     resourceGroup = "czwjstest";
-    resourcename = "resourcetest";
+    resourcename = "resourcetest1";
     scope = "subscriptions/" + subscriptionId;
+    scope1 = "subscriptions/" + subscriptionId + "/resourceGroups/myjstest/providers/Microsoft.KeyVault/vaults/testkey20230703";
   });
 
   afterEach(async function () {
@@ -71,6 +73,24 @@ describe("help test", () => {
       });
   });
 
+  it("diagnostics create test", async function () {
+    const options = {
+      diagnosticResourceRequest: {
+        insights: [
+          {
+            solutionId: "KeyVaultUnauthorizedNetworkInsight"
+          }
+        ]
+      }
+    }
+    const result = await client.diagnostics.beginCreateAndWait(
+      scope1,
+      resourcename,
+      options
+    );
+    assert.equal(result.name, resourcename);
+  });
+
   it("selfhelp operation test", async function () {
     const resArray = new Array();
     for await (let item of client.operations.list()) {