Remove the junit-vintage-engine from Spring projects (Azure#29160)

* stop using junit vintage engine * remove unused field
azure-sdk · Jun 6, 2022 · ea67fc5 · ea67fc5
1 parent 621d43e
commit ea67fc5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/sdk/spring/spring-cloud-azure-test-eventhubs-binder/pom.xml b/sdk/spring/spring-cloud-azure-test-eventhubs-binder/pom.xml
@@ -58,12 +58,6 @@
       <artifactId>spring-boot-starter-test</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.junit.vintage</groupId>
-      <artifactId>junit-vintage-engine</artifactId>
-      <version>5.8.2</version> <!-- {x-version-update;org.junit.vintage:junit-vintage-engine;external_dependency} -->
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 
   <build>

diff --git a/...der/src/test/java/com/azure/spring/sample/eventhubs/binder/EventHubsBinderSyncModeIT.java b/...der/src/test/java/com/azure/spring/sample/eventhubs/binder/EventHubsBinderSyncModeIT.java
@@ -3,14 +3,12 @@
 
 package com.azure.spring.sample.eventhubs.binder;
 
-import org.junit.Rule;
 import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
 import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.boot.test.system.OutputCaptureRule;
 import org.springframework.context.annotation.Bean;
 import org.springframework.messaging.Message;
 import org.springframework.messaging.support.GenericMessage;
@@ -42,9 +40,6 @@ class EventHubsBinderSyncModeIT {
     @Autowired
     private Sinks.Many<Message<String>> many;
 
-    @Rule
-    OutputCaptureRule capture = new OutputCaptureRule();
-
     private static final CountDownLatch LATCH = new CountDownLatch(1);
 
     @EnableAutoConfiguration

diff --git a/sdk/spring/spring-messaging-azure-eventhubs/pom.xml b/sdk/spring/spring-messaging-azure-eventhubs/pom.xml
@@ -111,14 +111,8 @@
     </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
-      <artifactId>junit-jupiter-api</artifactId>
-      <version>5.8.2</version> <!-- {x-version-update;org.junit.jupiter:junit-jupiter-api;external_dependency} -->
-      <scope>test</scope>
-    </dependency>
-    <dependency>
-      <groupId>org.junit.vintage</groupId>
-      <artifactId>junit-vintage-engine</artifactId>
-      <version>5.8.2</version> <!-- {x-version-update;org.junit.vintage:junit-vintage-engine;external_dependency} -->
+      <artifactId>junit-jupiter</artifactId>
+      <version>5.8.2</version> <!-- {x-version-update;org.junit.jupiter:junit-jupiter;external_dependency} -->
       <scope>test</scope>
     </dependency>
     <dependency>