Skip to content

Commit

Permalink
Sync eng/common directory with azure-sdk-tools for PR 3238 (Azure#17755)
Browse files Browse the repository at this point in the history
* pin proxy version to one that properly sets listenoptions
* targeted proxy repo is incorrect. "testproxy" -> "test-proxy"
* remove override now that the targeted version will work correctly

Co-authored-by: scbedd <[email protected]>
  • Loading branch information
azure-sdk and scbedd authored Apr 27, 2022
1 parent 3f7acd2 commit e4b9df8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion eng/common/testproxy/docker-start-proxy.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ catch {

$SELECTED_IMAGE_TAG = $(Get-Content "$PSScriptRoot/target_version.txt" -Raw).Trim()
$CONTAINER_NAME = "ambitious_azsdk_test_proxy"
$IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/testproxy:${SELECTED_IMAGE_TAG}"
$IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/test-proxy:${SELECTED_IMAGE_TAG}"

if($VersionOverride) {
Write-Host "Overriding default target proxy version of '$SELECTED_IMAGE_TAG' with override $VersionOverride."
Expand Down
2 changes: 1 addition & 1 deletion eng/common/testproxy/target_version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.0-dev.20220426.1
1.0.0-dev.20220427.1
3 changes: 0 additions & 3 deletions eng/pipelines/templates/steps/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ steps:
- ${{ if eq(parameters.TestProxy, true) }}:
- template: /eng/common/testproxy/test-proxy-tool.yml
parameters:
targetVersion: '1.0.0-dev.20220224.2'


- task: PowerShell@2
displayName: 'Run Tests'
Expand Down

0 comments on commit e4b9df8

Please sign in to comment.